averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[g-arc-opts] Use RCStateTransitions when processing arguments as well.

Browse Source 
Swift SVN r26914
This commit is contained in:
Michael Gottesman
2015-04-02 23:24:13 +00:00
parent c19f45aef8
commit 3c217614b0
6 changed files with 72 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
lib/SILAnalysis/GlobalARCSequenceDataflow.cpp
View File

@@ -60,6 +60,9 @@ static bool processBBTopDown(
bool NestingDetected = false;
TopDownDataflowRCStateVisitor DataflowVisitor(RCIA, BBState,
DecToIncStateMap);
// If the current BB is the entry BB, initialize a state corresponding to each
// of its owned parameters. This enables us to know that if we see a retain
// before any decrements that the retain is known safe.
@@ -68,27 +71,13 @@ static bool processBBTopDown(
// code in GlobalARCPairingAnalysis. This is because even if we don't do
// anything, we will still pair the retain, releases and then the guaranteed
// parameter will ensure it is known safe to remove them.
if (&BB == &*BB.getParent()->begin()) {
if (BB.isEntry()) {
auto Args = BB.getBBArgs();
auto SignatureParams =
BB.getParent()->getLoweredFunctionType()->getParameters();
for (unsigned i = 0, e = Args.size(); i != e; ++i) {
SILArgument *A = Args[i];
ParameterConvention P = SignatureParams[i].getConvention();
DEBUG(llvm::dbgs() << "VISITING ARGUMENT: " << *A);
if (P != ParameterConvention::Direct_Owned)
continue;
TopDownRefCountState &State = BBState.getTopDownRefCountState(Args[i]);
State.initWithArg(A);
DataflowVisitor.visit(Args[i]);
}
}
TopDownDataflowRCStateVisitor DataflowVisitor(RCIA, BBState,
DecToIncStateMap);
// For each instruction I in BB...
for (auto &I : BB) {