averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[NFC] Refactor Reference Dependency Emission

Browse Source 
Invert the responsibility of the entrypoint so that FrontendTool is directing the actual serialization work. The entrypoint now solely exists to construct a dependency graph.

While I'm here, prepare the way for serializing dependency graphs for modules by optimistically modeling a ModuleOrSourceFile input.
This commit is contained in:
Robert Widmann
2020-09-24 19:57:24 -06:00
parent dfdebfaddf
commit 3c2b376aa2
3 changed files with 56 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
lib/AST/FrontendSourceFileDepGraphFactory.cpp
View File

@@ -236,30 +236,20 @@ std::string DependencyKey::computeNameForProvidedEntity<
// MARK: Entry point into frontend graph construction
//==============================================================================
bool fine_grained_dependencies::emitReferenceDependencies(
DiagnosticEngine &diags, SourceFile *const SF,
const DependencyTracker &depTracker,
StringRef outputPath,
const bool alsoEmitDotFile) {
// Before writing to the dependencies file path, preserve any previous file
// that may have been there. No error handling -- this is just a nicety, it
// doesn't matter if it fails.
llvm::sys::fs::rename(outputPath, outputPath + "~");
SourceFileDepGraph g = FrontendSourceFileDepGraphFactory(
SF, outputPath, depTracker, alsoEmitDotFile)
.construct();
bool hadError = writeFineGrainedDependencyGraphToPath(diags, outputPath, g);
// If path is stdout, cannot read it back, so check for "-"
assert(outputPath == "-" || g.verifyReadsWhatIsWritten(outputPath));
if (alsoEmitDotFile)
g.emitDotFile(outputPath, diags);
return hadError;
bool fine_grained_dependencies::withReferenceDependencies(
llvm::PointerUnion<ModuleDecl *, SourceFile *> MSF,
const DependencyTracker &depTracker, StringRef outputPath,
bool alsoEmitDotFile,
llvm::function_ref<bool(SourceFileDepGraph &&)> cont) {
if (MSF.dyn_cast<ModuleDecl *>()) {
llvm_unreachable("Cannot construct dependency graph for modules!");
} else {
auto *SF = MSF.get<SourceFile *>();
SourceFileDepGraph g = FrontendSourceFileDepGraphFactory(
SF, outputPath, depTracker, alsoEmitDotFile)
.construct();
return cont(std::move(g));
}
}
//==============================================================================