averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[region-isolation] Implement MergeIsolationRegionInst.

Browse Source 
I am adding this instruction to express artificially that two non-Sendable
values should be part of the same region. It is meant to be used in cases where
due to unsafe code using Sendable, we stop propagating a non-Sendable dependency
that needs to be made in the same region of a use of said Sendable value. I
included an example in ./docs/SIL.rst of where this comes up with @out results
of continuations.
This commit is contained in:
Michael Gottesman
2024-10-26 13:40:48 -07:00
parent dddfdc891f
commit 3c38c79f7a
26 changed files with 301 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
lib/Serialization/SerializeSIL.cpp
View File

@@ -2426,6 +2426,27 @@ void SILSerializer::writeSILInstruction(const SILInstruction &SI) {
(unsigned)TI->getType().getCategory(), ListOfValues);
break;
}
case SILInstructionKind::MergeIsolationRegionInst: {
const auto *mir = cast<MergeIsolationRegionInst>(&SI);
SmallVector<uint64_t, 4> ListOfValues;
auto getValue = [&](SILValue value) -> uint64_t {
uint32_t result = addValueRef(value);
// Set the top bit if we are an address. We only transfer raw ast types,
// so we lose this bit otherwise. This is safe since all of our IDs are
// guaranteed to be 31 bits meaning we can always take the top bit.
result |= value->getType().isObject() ? 0 : 0x80000000;
return result;
};
for (auto value : mir->getArguments()) {
ListOfValues.push_back(getValue(value));
ListOfValues.push_back(S.addTypeRef(value->getType().getRawASTType()));
}
unsigned abbrCode = SILAbbrCodes[SILValuesLayout::Code];
SILValuesLayout::emitRecord(Out, ScratchRecord, abbrCode,
(unsigned)SI.getKind(), ListOfValues);
break;
}
case SILInstructionKind::TupleAddrConstructorInst: {
// Format: a type followed by a list of values. A value is expressed by
// 2 IDs: ValueID, ValueResultNumber.
@@ -3231,6 +3252,7 @@ void SILSerializer::writeSILBlock(const SILModule *SILMod) {
registerSILAbbr<SILOneTypeValuesLayout>();
registerSILAbbr<SILOneTypeOwnershipValuesLayout>();
registerSILAbbr<SILOneTypeValuesCategoriesLayout>();
registerSILAbbr<SILValuesLayout>();
registerSILAbbr<SILTwoOperandsLayout>();
registerSILAbbr<SILTwoOperandsExtraAttributeLayout>();
registerSILAbbr<SILTailAddrLayout>();