averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #85106 from kateinoigakukun/yt/fix-dead-stub-comdat-wasm

Browse Source 
[wasm][IRGen] Stop attaching COMDATs to dead stub methods
This commit is contained in:
Yuta Saito
2025-10-29 15:29:48 +09:00
committed by GitHub
parent 9cd81d2065 50298bd8e5
commit 3e834ccf9f
3 changed files with 54 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
test/IRGen/dead-stub-method-dedup.swift Normal file
View File

@@ -0,0 +1,42 @@
// RUN: %empty-directory(%t)
// RUN: split-file --leading-lines %s %t
// Note: IRGen uses internal linkage instead of linkonce_odr only for COFF for dead stub methods.
// UNSUPPORTED: OS=windows-msvc
// Ensure that swift_dead_method_stub is emitted without comdat linkage
// RUN: %target-swift-frontend -target %target-swift-5.1-abi-triple -parse-as-library -O -module-name A -c -primary-file %t/A.swift %t/B.swift -emit-ir -o - | %FileCheck %s -check-prefix CHECK
// RUN: %target-swift-frontend -target %target-swift-5.1-abi-triple -parse-as-library -O -module-name A -c %t/A.swift -primary-file %t/B.swift -emit-ir -o - | %FileCheck %s -check-prefix CHECK
// CHECK-LABEL: define {{(linkonce_odr )?}}hidden void @_swift_dead_method_stub(
// CHECK-NOT: comdat
// CHECK: {
// Ensure that link-time deduplication for swift_dead_method_stub works correctly
// RUN: %target-swift-frontend -target %target-swift-5.1-abi-triple -parse-as-library -O -module-name A -c -primary-file %t/A.swift %t/B.swift -o %t/A.swift.o
// RUN: %target-swift-frontend -target %target-swift-5.1-abi-triple -parse-as-library -O -module-name A -c %t/A.swift -primary-file %t/B.swift -o %t/B.swift.o
// RUN: %target-build-swift -target %target-swift-5.1-abi-triple %t/B.swift.o %t/A.swift.o -o %t/a.out
//--- A.swift
// Define an open class with a dead vtable entry
class C1 {
private func dead() {}
}
//--- B.swift
class C2: C1 {
// Define another dead vtable entry to ensure that this object file
// also should have dead vtable stub definition
private func beef() {}
}
@main
struct Entry {
static func main() {
_ = C2()
}
}