mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
[benchmark] Extract setup from IterateData
IterateData has setup overhead of 480 μs (10%). There remained strange setup overhead after extracting the data into setUpFunction, because of of-by-one error in the main loop. It should be either: `for _ 1…10*N` or: `for _ 0..<10*N`. It’s error to use 0…m*N, because this will result in `m*N + 1` iterations that will be divided by N in the reported measurement. The extra iteration then manifests as a mysterious setup overhead!
This commit is contained in:
@@ -16,10 +16,10 @@ import Foundation
|
||||
public let IterateData = BenchmarkInfo(
|
||||
name: "IterateData",
|
||||
runFunction: run_IterateData,
|
||||
tags: [.validation, .api, .Data])
|
||||
tags: [.validation, .api, .Data],
|
||||
setUpFunction: { blackHole(data) })
|
||||
|
||||
@inline(never)
|
||||
func generateData() -> Data {
|
||||
let data: Data = {
|
||||
var data = Data(count: 16 * 1024)
|
||||
let n = data.count
|
||||
data.withUnsafeMutableBytes { (ptr: UnsafeMutablePointer<UInt8>) -> () in
|
||||
@@ -28,13 +28,11 @@ func generateData() -> Data {
|
||||
}
|
||||
}
|
||||
return data
|
||||
}
|
||||
}()
|
||||
|
||||
@inline(never)
|
||||
public func run_IterateData(_ N: Int) {
|
||||
let data = generateData()
|
||||
|
||||
for _ in 0...10*N {
|
||||
for _ in 1...10*N {
|
||||
_ = data.reduce(0, &+)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user