averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Assert that makeDeclUsableFromInline is not called in Package CMO mode.

Browse Source 
Removes a workaround previously added to handle types that were
overlooked during a serializability detection pass. Now that the
pass has been refactored with instruction visitor, we can replace
it with assert.

Resolves rdar://137711038
This commit is contained in:
elsh
2024-10-10 15:23:34 -07:00
parent 23a049c38d
commit 415ede4f4a
1 changed files with 4 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
lib/SILOptimizer/IPO/CrossModuleOptimization.cpp
View File

@@ -995,25 +995,13 @@ void CrossModuleOptimization::makeFunctionUsableFromInline(SILFunction *function
}
}
/// Make a nominal type, including it's context, usable from inline.
/// Make a nominal type, including its context, usable from inline.
void CrossModuleOptimization::makeDeclUsableFromInline(ValueDecl *decl) {
if (decl->getEffectiveAccess() >= AccessLevel::Package)
return;
return;
// FIXME: rdar://130456707
// Currently not all types are visited in canSerialize* calls, sometimes
// resulting in an internal type getting @usableFromInline, which is
// incorrect.
// For example, for `let q = P() as? Q`, where Q is an internal class
// inherting a public class P, Q is not visited in the canSerialize*
// checks, thus resulting in `@usableFromInline class Q`; this is not
// the intended behavior in the conservative mode as it modifies AST.
//
// To properly fix, instruction visitor needs to be refactored to do
// both the "canSerialize" check (that visits all types) and serialize
// or update visibility (modify AST in non-conservative modes).
if (isPackageCMOEnabled(M.getSwiftModule()))
return;
// This function should not be called in Package CMO mode.
assert(!isPackageCMOEnabled(M.getSwiftModule()));
// We must not modify decls which are defined in other modules.
if (M.getSwiftModule() != decl->getDeclContext()->getParentModule())