averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[serialization] Stop recording the full paths to input source files.

Browse Source 
There were no clients and it leaks information about the developer's system.
After this commit, there should be no full paths present in framework modules.
(App modules may contain search paths for debugging reasons, as well as a
full or relative path to the bridging header.)

Swift SVN r24851
This commit is contained in:
Jordan Rose
2015-01-30 19:22:34 +00:00
parent 2ff77a9cd1
commit 478fdcf3ab
4 changed files with 2 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/Serialization/Serialization.cpp
View File

@@ -398,7 +398,6 @@ void Serializer::writeBlockInfoBlock() {
BLOCK_RECORD(control_block, TARGET);
BLOCK(INPUT_BLOCK);
BLOCK_RECORD(input_block, SOURCE_FILE);
BLOCK_RECORD(input_block, IMPORTED_MODULE);
BLOCK_RECORD(input_block, LINK_LIBRARY);
BLOCK_RECORD(input_block, IMPORTED_HEADER);
@@ -589,7 +588,6 @@ static void flattenImportPath(const Module::ImportedModule &import,
void Serializer::writeInputBlock(const SerializationOptions &options) {
BCBlockRAII restoreBlock(Out, INPUT_BLOCK_ID, 4);
input_block::SourceFileLayout SourceFile(Out);
input_block::ImportedModuleLayout ImportedModule(Out);
input_block::LinkLibraryLayout LinkLibrary(Out);
input_block::ImportedHeaderLayout ImportedHeader(Out);
@@ -605,17 +603,6 @@ void Serializer::writeInputBlock(const SerializationOptions &options) {
SearchPath.emit(ScratchRecord, /*framework=*/true, path);
}
for (auto filename : options.InputFilenames) {
llvm::SmallString<128> path(filename);
std::error_code err;
err = llvm::sys::fs::make_absolute(path);
if (err)
continue;
SourceFile.emit(ScratchRecord, path);
}
// FIXME: Having to deal with private imports as a superset of public imports
// is inefficient.
SmallVector<Module::ImportedModule, 8> publicImports;