averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[stdlib] Align behavior of generic NaN conversion to that of concrete types (#17746)

Browse Source
This commit is contained in:
Xiaodi Wu
2018-07-05 08:28:51 -04:00
committed by Stephen Canon
parent 00843da713
commit 47f13ec9ff
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
stdlib/public/core/FloatingPoint.swift.gyb
View File

@@ -2185,7 +2185,9 @@ extension BinaryFloatingPoint {
sign: source.sign,
exponentBitPattern: Self.nan.exponentBitPattern,
significandBitPattern: payload | Self.nan.significandBitPattern)
return payload_ == payload ? (value, true) : (value, false)
// We define exactness by equality after roundtripping; since NaN is never
// equal to itself, it can never be converted exactly.
return (value, false)
}
let exponent = source.exponent
@@ -2299,8 +2301,7 @@ extension BinaryFloatingPoint {
/// exactly.
///
/// If the given floating-point value cannot be represented exactly, the
/// result is `nil`. A value that is NaN ("not a number") cannot be
/// represented exactly if its payload cannot be encoded exactly.
/// result is `nil`.
///
/// - Parameter value: A floating-point value to be converted.
@inlinable // FIXME(sil-serialize-all)