averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[gardening] Remove redundant repetition of type names (DRY): RepeatedTypeName foo = dyn_cast<RepeatedTypeName>(bar)

Browse Source 
Replace `NameOfType foo = dyn_cast<NameOfType>(bar)` with DRY version `auto foo = dyn_cast<NameOfType>(bar)`.

The DRY auto version is by far the dominant form already used in the repo, so this PR merely brings the exceptional cases (redundant repetition form) in line with the dominant form (auto form).

See the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es11-use-auto-to-avoid-redundant-repetition-of-type-names) for a general discussion on why to use `auto` to avoid redundant repetition of type names.
This commit is contained in:
practicalswift
2017-05-05 09:38:49 +02:00
parent c6ef8022ae
commit 492f5cd35a
123 changed files with 407 additions and 407 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
lib/SILOptimizer/Transforms/SILCodeMotion.cpp
View File

@@ -123,7 +123,7 @@ static bool hoistSILArgumentReleaseInst(SILBasicBlock *BB) {
return false;
// Make sure it is a release on a SILArgument of the current basic block..
SILArgument *SA = dyn_cast<SILArgument>(Head->getOperand(0));
auto *SA = dyn_cast<SILArgument>(Head->getOperand(0));
if (!SA || SA->getParent() != BB)
return false;
@@ -203,7 +203,7 @@ enum OperandRelation {
static SILValue findValueShallowRoot(const SILValue &In) {
// If this is a basic block argument with a single caller
// then we know exactly which value is passed to the argument.
if (SILArgument *Arg = dyn_cast<SILArgument>(In)) {
if (auto *Arg = dyn_cast<SILArgument>(In)) {
SILBasicBlock *Parent = Arg->getParent();
SILBasicBlock *Pred = Parent->getSinglePredecessorBlock();
if (!Pred) return In;
@@ -309,15 +309,15 @@ cheaperToPassOperandsAsArguments(SILInstruction *First,
// This will further enable to sink strong_retain_unowned instructions,
// which provides more opportunities for the unowned-optimization in
// LLVMARCOpts.
UnownedToRefInst *UTORI1 = dyn_cast<UnownedToRefInst>(First);
UnownedToRefInst *UTORI2 = dyn_cast<UnownedToRefInst>(Second);
auto *UTORI1 = dyn_cast<UnownedToRefInst>(First);
auto *UTORI2 = dyn_cast<UnownedToRefInst>(Second);
if (UTORI1 && UTORI2) {
return 0;
}
// TODO: Add more cases than Struct
StructInst *FirstStruct = dyn_cast<StructInst>(First);
StructInst *SecondStruct = dyn_cast<StructInst>(Second);
auto *FirstStruct = dyn_cast<StructInst>(First);
auto *SecondStruct = dyn_cast<StructInst>(Second);
if (!FirstStruct || !SecondStruct)
return None;
@@ -408,7 +408,7 @@ static bool sinkArgument(SILBasicBlock *BB, unsigned ArgNum) {
SILBasicBlock *FirstPred = *BB->pred_begin();
TermInst *FirstTerm = FirstPred->getTerminator();
auto FirstPredArg = FirstTerm->getOperand(ArgNum);
SILInstruction *FSI = dyn_cast<SILInstruction>(FirstPredArg);
auto *FSI = dyn_cast<SILInstruction>(FirstPredArg);
// The list of identical instructions.
SmallVector<SILValue, 8> Clones;
@@ -443,7 +443,7 @@ static bool sinkArgument(SILBasicBlock *BB, unsigned ArgNum) {
// Find the Nth argument passed to BB.
SILValue Arg = TI->getOperand(ArgNum);
SILInstruction *SI = dyn_cast<SILInstruction>(Arg);
auto *SI = dyn_cast<SILInstruction>(Arg);
if (!SI || !hasOneNonDebugUse(SI))
return false;
if (SI->isIdenticalTo(FSI)) {
@@ -495,7 +495,7 @@ static bool sinkArgument(SILBasicBlock *BB, unsigned ArgNum) {
assert((isa<BranchInst>(TI) || isa<CondBranchInst>(TI)) &&
"Branch instruction required");
SILInstruction *CloneInst = dyn_cast<SILInstruction>(*CloneIt);
auto *CloneInst = dyn_cast<SILInstruction>(*CloneIt);
TI->setOperand(ArgNum, CloneInst->getOperand(*DifferentOperandIndex));
// Now delete the clone as we only needed it operand.
if (CloneInst != FSI)
@@ -1078,7 +1078,7 @@ void BBEnumTagDataflowState::handlePredSwitchEnum(SwitchEnumInst *S) {
void BBEnumTagDataflowState::handlePredCondSelectEnum(CondBranchInst *CondBr) {
SelectEnumInst *EITI = dyn_cast<SelectEnumInst>(CondBr->getCondition());
auto *EITI = dyn_cast<SelectEnumInst>(CondBr->getCondition());
if (!EITI)
return;