averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[ClangImporter] Fix another lifetime extension issue. (#5255)

Browse Source 
The StringRef here referred to a temporary std::string.

rdar://problem/28699869
This commit is contained in:
Jordan Rose
2016-10-13 13:47:37 -07:00
committed by GitHub
parent 6ce4be96f1
commit 4960ad14da
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/ClangImporter/ClangImporter.cpp
View File

@@ -1137,8 +1137,9 @@ void ClangImporter::collectSubModuleNames(
}
auto submoduleNameLength = submodule->getFullModuleName().length();
for (auto sub : submodule->submodules()) {
StringRef full = sub->getFullModuleName();
names.push_back(full.substr(submoduleNameLength + 1).str());
std::string full = sub->getFullModuleName();
full.erase(0, submoduleNameLength + 1);
names.push_back(std::move(full));
}
}