averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

swift-module-digester: diagnose type witness type changes when checking ABI stability.

Browse Source
This commit is contained in:
Xi Ge
2018-10-25 16:37:42 -07:00
parent e7c2bf0ab9
commit 49c16922dd
9 changed files with 44 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tools/swift-api-digester/swift-api-digester.cpp
View File

@@ -859,7 +859,21 @@ void swift::ide::api::SDKNodeType::diagnose(SDKNode *Right) {
if (!RT || !shouldDiagnoseType(this))
return;
assert(isTopLevelType());
// Diagnose type witness changes when diagnosing ABI breakages.
if (auto *Wit = dyn_cast<SDKNodeTypeWitness>(getParent())) {
auto *Conform = Wit->getParent()->getAs<SDKNodeConformance>();
if (Ctx.checkingABI() && getPrintedName() != RT->getPrintedName()) {
Diags.diagnose(SourceLoc(), diag::type_witness_change,
Conform->getNominalTypeDecl()->getScreenInfo(),
Wit->getWitnessedTypeName(),
getPrintedName(), RT->getPrintedName());
}
return;
}
StringRef Descriptor = getTypeRoleDescription();
assert(isa<SDKNodeDecl>(getParent()));
auto LParent = cast<SDKNodeDecl>(getParent());
assert(LParent->getKind() == RT->getParent()->getAs<SDKNodeDecl>()->getKind());