averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Code completion: don't copy static strings into a separate allocator

Browse Source 
Swift SVN r9484
This commit is contained in:
Dmitri Hrybenko
2013-10-18 18:04:41 +00:00
parent ae03a13d54
commit 4e29c56cdd
2 changed files with 31 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
include/swift/IDE/CodeCompletion.h
View File

@@ -343,6 +343,12 @@ class CodeCompletionResultBuilder {
void addChunkWithText(CodeCompletionString::Chunk::ChunkKind Kind,
StringRef Text);
void addChunkWithTextNoCopy(CodeCompletionString::Chunk::ChunkKind Kind,
StringRef Text) {
Chunks.push_back(CodeCompletionString::Chunk::createWithText(
Kind, CurrentNestingLevel, Text));
}
void addSimpleChunk(CodeCompletionString::Chunk::ChunkKind Kind) {
Chunks.push_back(
CodeCompletionString::Chunk::createSimple(Kind,
@@ -377,27 +383,33 @@ public:
}
void addLeftParen() {
addChunkWithText(CodeCompletionString::Chunk::ChunkKind::LeftParen, "(");
addChunkWithTextNoCopy(
CodeCompletionString::Chunk::ChunkKind::LeftParen, "(");
}
void addRightParen() {
addChunkWithText(CodeCompletionString::Chunk::ChunkKind::RightParen, ")");
addChunkWithTextNoCopy(
CodeCompletionString::Chunk::ChunkKind::RightParen, ")");
}
void addLeftBracket() {
addChunkWithText(CodeCompletionString::Chunk::ChunkKind::LeftBracket, "[");
addChunkWithTextNoCopy(
CodeCompletionString::Chunk::ChunkKind::LeftBracket, "[");
}
void addRightBracket() {
addChunkWithText(CodeCompletionString::Chunk::ChunkKind::RightBracket, "]");
addChunkWithTextNoCopy(
CodeCompletionString::Chunk::ChunkKind::RightBracket, "]");
}
void addLeftAngle() {
addChunkWithText(CodeCompletionString::Chunk::ChunkKind::LeftAngle, "<");
addChunkWithTextNoCopy(
CodeCompletionString::Chunk::ChunkKind::LeftAngle, "<");
}
void addRightAngle() {
addChunkWithText(CodeCompletionString::Chunk::ChunkKind::RightAngle, ">");
addChunkWithTextNoCopy(
CodeCompletionString::Chunk::ChunkKind::RightAngle, ">");
}
void addLeadingDot() {
@@ -406,22 +418,21 @@ public:
}
void addDot() {
addChunkWithText(CodeCompletionString::Chunk::ChunkKind::Dot, ".");
addChunkWithTextNoCopy(CodeCompletionString::Chunk::ChunkKind::Dot, ".");
}
void addComma(StringRef Text) {
if (Text.empty())
Text = ",";
addChunkWithText(CodeCompletionString::Chunk::ChunkKind::Comma, Text);
void addComma() {
addChunkWithTextNoCopy(
CodeCompletionString::Chunk::ChunkKind::Comma, ", ");
}
void addExclamationMark() {
addChunkWithText(
addChunkWithTextNoCopy(
CodeCompletionString::Chunk::ChunkKind::ExclamationMark, "!");
}
void addQuestionMark() {
addChunkWithText(
addChunkWithTextNoCopy(
CodeCompletionString::Chunk::ChunkKind::QuestionMark, "?");
}