averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[stdlib] ArrayCast discipline

Browse Source 
use withUnsafeMutableBufferPointer rather than accessing _elementStorage
directly, where possible

Swift SVN r22778
This commit is contained in:
Dave Abrahams
2014-10-15 22:25:11 +00:00
parent fe68e7512f
commit 4e31ae0a44
1 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
stdlib/core/ArrayCast.swift
View File

@@ -42,7 +42,9 @@ case Verbatim, Explicit
public func _arrayForceCast<SourceElement, TargetElement>(
source: Array<SourceElement>
) -> Array<TargetElement> {
switch (_ValueOrReference(SourceElement.self), _BridgeStyle(TargetElement.self)) {
switch (
_ValueOrReference(SourceElement.self), _BridgeStyle(TargetElement.self)
) {
case (.Reference, .Verbatim):
let native = source._buffer.requestNativeBuffer()
@@ -62,12 +64,18 @@ public func _arrayForceCast<SourceElement, TargetElement>(
return result!
case (.Value, .Verbatim):
var buf = _ContiguousArrayBuffer<TargetElement>(count: source.count, minimumCapacity: 0)
var p = buf._unsafeElementStorage
for value in source {
let bridged: AnyObject? = _bridgeToObjectiveC(value)
_precondition(bridged != nil, "array element cannot be bridged to Objective-C")
p++.initialize(unsafeBitCast(bridged!, TargetElement.self))
var buf = _ContiguousArrayBuffer<TargetElement>(
count: source.count, minimumCapacity: 0)
let _: Void = buf.withUnsafeMutableBufferPointer {
var p = $0.baseAddress
for value in source {
let bridged: AnyObject? = _bridgeToObjectiveC(value)
_precondition(
bridged != nil, "array element cannot be bridged to Objective-C")
// FIXME: should be an unsafeDowncast, but for <rdar://problem/18638230>
p++.initialize(unsafeBitCast(bridged!, TargetElement.self))
}
}
return Array(_ArrayBuffer(buf))