averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

swift-module-digester: added protocol requirements can be source-breaking.

Browse Source
This commit is contained in:
Xi Ge
2018-09-23 08:48:05 -07:00
parent a64ae05454
commit 4e3f8f4784
8 changed files with 93 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tools/swift-api-digester/swift-api-digester.cpp
View File

@@ -813,6 +813,20 @@ public:
}
}
}
// Complain about added protocol requirements
if (auto *D = dyn_cast<SDKNodeDecl>(Right)) {
if (D->isProtocolRequirement()) {
bool ShouldComplain = true;
// We should allow added associated types with default.
if (auto ATD = dyn_cast<SDKNodeDeclAssociatedType>(D)) {
if (ATD->getDefault())
ShouldComplain = false;
}
if (ShouldComplain)
Ctx.getDiags().diagnose(SourceLoc(), diag::protocol_req_added,
D->getScreenInfo());
}
}
return;
case NodeMatchReason::Removed:
assert(!Right);