averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[SourceKit] Attempt to make EditingTest deterministic

Browse Source 
The previous code actually had a "semantic" error as well as a parse
error, so depending on the timing we could get 2 diagnosticsl

rdar://problem/34373697
This commit is contained in:
Ben Langmuir
2017-09-12 09:55:11 -07:00
parent 6ce063f769
commit 4eebeea1f9
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
unittests/SourceKit/SwiftLang/EditingTest.cpp
View File

@@ -192,17 +192,17 @@ static UIdent ParseDiagStage("source.diagnostic.stage.swift.parse");
TEST_F(EditTest, DiagsAfterEdit) { TEST_F(EditTest, DiagsAfterEdit) {
const char *DocName = "/test.swift"; const char *DocName = "/test.swift";
const char *Contents = const char *Contents =
"func foo\n" "func foo {}\n"
"let v = 0\n"; "let v = 0\n";
const char *Args[] = { "-parse-as-library" }; const char *Args[] = { "-parse-as-library" };
DiagConsumer Consumer; DiagConsumer Consumer;
open(DocName, Contents, Args, Consumer); open(DocName, Contents, Args, Consumer);
ASSERT_TRUE(Consumer.Diags.size() == 1); ASSERT_EQ(1u, Consumer.Diags.size());
EXPECT_STREQ("expected '(' in argument list of function declaration", Consumer.Diags[0].Description.c_str()); EXPECT_STREQ("expected '(' in argument list of function declaration", Consumer.Diags[0].Description.c_str());
reset(Consumer); reset(Consumer);
replaceText(DocName, findOffset("func foo", Contents)+strlen("func foo"), 0, "(){}", Consumer); replaceText(DocName, findOffset("func foo", Contents)+strlen("func foo"), 0, "()", Consumer);
EXPECT_TRUE(Consumer.Diags.empty()); EXPECT_TRUE(Consumer.Diags.empty());
bool expired = waitForDocUpdate(); bool expired = waitForDocUpdate();