averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Switch ValueDecl::getObjCSelector() and friends over to ObjCSelector.

Browse Source 
Formatting names into strings repeatedly, and using those for semantic
analysis, is generally considered poor form. Additionally, use the
camelCase utilities to perform the string manipulation we need, and
cache results on the ObjCAttr so we don't repeatedly do string
manipulation.

Swift SVN r16334
This commit is contained in:
Doug Gregor
2014-04-14 22:02:51 +00:00
parent 204c7006c4
commit 53b84c121e
9 changed files with 157 additions and 155 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
include/swift/AST/Decl.h
View File

@@ -3049,12 +3049,12 @@ public:
bool usesObjCGetterAndSetter() const;
/// Given that this is an Objective-C property or subscript declaration,
/// produce its getter selector in the given buffer (as UTF-8).
StringRef getObjCGetterSelector(SmallVectorImpl<char> &buffer) const;
/// produce its getter selector.
ObjCSelector getObjCGetterSelector() const;
/// Given that this is an Objective-C property or subscript declaration,
/// produce its setter selector in the given buffer (as UTF-8).
StringRef getObjCSetterSelector(SmallVectorImpl<char> &buffer) const;
/// produce its setter selector.
ObjCSelector getObjCSetterSelector() const;
AbstractStorageDecl *getOverriddenDecl() const {
return OverriddenDecl.getPointer();
@@ -3373,7 +3373,7 @@ public:
}
/// Retrieve the Objective-C selector that names this method.
StringRef getObjCSelector(SmallVectorImpl<char> &buffer) const;
ObjCSelector getObjCSelector() const;
/// Determine the default argument kind and type for the given argument index
/// in this declaration, which must be a function or constructor.
@@ -3722,9 +3722,8 @@ public:
/// return type.
DynamicSelfType *getDynamicSelfInterface() const;
/// Given that this is an Objective-C method declaration, produce
/// its selector in the given buffer (as UTF-8).
StringRef getObjCSelector(SmallVectorImpl<char> &buffer) const;
/// Given that this is an Objective-C method declaration, get its selector.
ObjCSelector getObjCSelector() const;
void getLocalCaptures(SmallVectorImpl<CaptureInfo::
LocalCaptureTy> &Result) const {
@@ -3955,9 +3954,8 @@ public:
/// \brief Get the type of the constructed object.
Type getResultType() const;
/// Given that this is an Objective-C method declaration, produce
/// its selector in the given buffer (as UTF-8).
StringRef getObjCSelector(SmallVectorImpl<char> &buffer) const;
/// Given that this is an Objective-C method declaration, get its selector.
ObjCSelector getObjCSelector() const;
/// Get the type of the initializing constructor.
Type getInitializerType() const { return InitializerType; }
@@ -4075,7 +4073,7 @@ public:
/// Retrieve the Objective-C selector associated with the destructor.
///
/// This is always "dealloc".
StringRef getObjCSelector(SmallVectorImpl<char> &buffer) const;
ObjCSelector getObjCSelector() const;
static bool classof(const Decl *D) {
return D->getKind() == DeclKind::Destructor;