averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Sema] Restrict reexported SPIs to modules with an export_as relationship

Browse Source 
@_exported exports SPIs only when the exported module defines export_as
pointing to the exporter module. Other reexports do not reexport SPIs.
This is to prevent SPI reexporting to get out of hands with the wide
reexports of the Objective-C world.

rdar://102335473
This commit is contained in:
Alexis Laferrière
2022-11-14 12:30:37 -08:00
parent e52fbb89c1
commit 552d3a4984
3 changed files with 43 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/AST/Module.cpp
View File

@@ -2861,7 +2861,8 @@ void SourceFile::lookupImportedSPIGroups(
for (auto &import : *Imports) {
if (import.options.contains(ImportFlags::SPIAccessControl) &&
(importedModule == import.module.importedModule ||
imports.isImportedBy(importedModule, import.module.importedModule))) {
(imports.isImportedBy(importedModule, import.module.importedModule) &&
importedModule->isExportedAs(import.module.importedModule)))) {
spiGroups.insert(import.spiGroups.begin(), import.spiGroups.end());
}
}