averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup and document SIL memory behavior APIs.

Browse Source 
This is code that I am fairly familiar with but it still took a day of
investigation to figure out how it is supposed to be used now in the
presence of bridging.

This primarily involved ruling out the possibity that the mid-level
Swift APIs could at some point call into the lower-level C++ APIs.

The biggest problem was that AliasAnalysis::getMemoryBehaviorOfInst()
was declared as a public interface, and it's name indicates that it
computes the memory behavior. But it is just a wrapper around a Swift
API and never actually calls into any of the C++ logic that is
responsible for computing memory behavior!
This commit is contained in:
Andrew Trick
2023-07-07 20:54:31 -07:00
parent b426c1507d
commit 5bae8551ff
4 changed files with 59 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
lib/SILOptimizer/Analysis/MemoryBehavior.cpp
View File

@@ -317,50 +317,50 @@ MemBehavior MemoryBehaviorVisitor::visitMarkUnresolvedMoveAddrInst(
MemBehavior MemoryBehaviorVisitor::visitBuiltinInst(BuiltinInst *BI) {
MemBehavior mb = BI->getMemoryBehavior();
if (mb != MemBehavior::None) {
return AA->getMemoryBehaviorOfInst(V, BI);
return AA->getMemoryEffectOnEscapedAddress(V, BI);
}
return MemBehavior::None;
}
MemBehavior MemoryBehaviorVisitor::visitTryApplyInst(TryApplyInst *AI) {
return AA->getMemoryBehaviorOfInst(V, AI);
return AA->getMemoryEffectOnEscapedAddress(V, AI);
}
MemBehavior MemoryBehaviorVisitor::visitApplyInst(ApplyInst *AI) {
return AA->getMemoryBehaviorOfInst(V, AI);
return AA->getMemoryEffectOnEscapedAddress(V, AI);
}
MemBehavior MemoryBehaviorVisitor::visitBeginApplyInst(BeginApplyInst *AI) {
return AA->getMemoryBehaviorOfInst(V, AI);
return AA->getMemoryEffectOnEscapedAddress(V, AI);
}
MemBehavior MemoryBehaviorVisitor::visitEndApplyInst(EndApplyInst *EAI) {
return AA->getMemoryBehaviorOfInst(V, EAI->getBeginApply());
return AA->getMemoryEffectOnEscapedAddress(V, EAI->getBeginApply());
}
MemBehavior MemoryBehaviorVisitor::visitAbortApplyInst(AbortApplyInst *AAI) {
return AA->getMemoryBehaviorOfInst(V, AAI->getBeginApply());
return AA->getMemoryEffectOnEscapedAddress(V, AAI->getBeginApply());
}
MemBehavior
MemoryBehaviorVisitor::visitStrongReleaseInst(StrongReleaseInst *SI) {
return AA->getMemoryBehaviorOfInst(V, SI);
return AA->getMemoryEffectOnEscapedAddress(V, SI);
}
#define ALWAYS_OR_SOMETIMES_LOADABLE_CHECKED_REF_STORAGE(Name, ...) \
MemBehavior \
MemoryBehaviorVisitor::visit##Name##ReleaseInst(Name##ReleaseInst *SI) { \
return AA->getMemoryBehaviorOfInst(V, SI); \
return AA->getMemoryEffectOnEscapedAddress(V, SI); \
}
#include "swift/AST/ReferenceStorage.def"
MemBehavior MemoryBehaviorVisitor::visitReleaseValueInst(ReleaseValueInst *SI) {
return AA->getMemoryBehaviorOfInst(V, SI);
return AA->getMemoryEffectOnEscapedAddress(V, SI);
}
MemBehavior
MemoryBehaviorVisitor::visitDestroyValueInst(DestroyValueInst *DVI) {
return AA->getMemoryBehaviorOfInst(V, DVI);
return AA->getMemoryEffectOnEscapedAddress(V, DVI);
}
MemBehavior MemoryBehaviorVisitor::visitSetDeallocatingInst(SetDeallocatingInst *SDI) {