averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Refactoring] Fix invalid legacy body for Result<Void, ...> handler

Browse Source 
When adding an async alternative for a function with a
`(Result<Void, ...>) -> Void` completion handler, the legacy body was
adding a call to the handler with `.success(result)`. We don't assign to
`result` for `Void` handlers, so pass `()` instead.

Resolves rdar://81829392
This commit is contained in:
Ben Barham
2021-08-12 20:46:28 +10:00
parent 81f2be251b
commit 5bd2d0b932
2 changed files with 22 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
test/refactoring/ConvertAsync/basic.swift
View File

@@ -475,6 +475,21 @@ func voidAndErrorCompletion(completion: @escaping (Void, Error?) -> Void) {}
// VOID-AND-ERROR-HANDLER-NEXT: }
// VOID-AND-ERROR-HANDLER: func voidAndErrorCompletion() async throws {}
// RUN: %refactor-check-compiles -add-async-alternative -dump-text -source-filename %s -pos=%(line+1):1 | %FileCheck -check-prefix VOID-RESULT-HANDLER %s
func voidResultCompletion(completion: @escaping (Result<Void, Error>) -> Void) {}
// VOID-RESULT-HANDLER: {
// VOID-RESULT-HANDLER-NEXT: Task {
// VOID-RESULT-HANDLER-NEXT: do {
// VOID-RESULT-HANDLER-NEXT: try await voidResultCompletion()
// VOID-RESULT-HANDLER-NEXT: completion(.success(()))
// VOID-RESULT-HANDLER-NEXT: } catch {
// VOID-RESULT-HANDLER-NEXT: completion(.failure(error))
// VOID-RESULT-HANDLER-NEXT: }
// VOID-RESULT-HANDLER-NEXT: }
// VOID-RESULT-HANDLER-NEXT: }
// VOID-RESULT-HANDLER: func voidResultCompletion() async throws {
// 2. Check that the various ways to call a function (and the positions the
// refactoring is called from) are handled correctly