mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
Improve the performance of IRGenDebugInfo
This commit changes how inline information is stored in SILDebugScope from a tree to a linear chain of inlined call sites (similar to what LLVM is using). This makes creating inlined SILDebugScopes slightly more expensive, but makes lowering SILDebugScopes into LLVM metadata much faster because entire inlined-at chains can now be cached. This means that SIL is no longer preserve the inlining history (i.e., ((a was inlined into b) was inlined into c) is represented the same as (a was inlined into (b was inlined into c)), but this information was not used by anyone. On my late 2012 i7 iMac, this saves about 4 seconds when compiling the RelWithDebInfo x86_64 swift standard library — or 40% of IRGen time. rdar://problem/28311051
This commit is contained in:
57
lib/SIL/SILDebugScope.cpp
Normal file
57
lib/SIL/SILDebugScope.cpp
Normal file
@@ -0,0 +1,57 @@
|
||||
//===--- SILDebugScope.h - DebugScopes for SIL code -------------*- C++ -*-===//
|
||||
//
|
||||
// This source file is part of the Swift.org open source project
|
||||
//
|
||||
// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
|
||||
// Licensed under Apache License v2.0 with Runtime Library Exception
|
||||
//
|
||||
// See https://swift.org/LICENSE.txt for license information
|
||||
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
|
||||
//
|
||||
//===----------------------------------------------------------------------===//
|
||||
///
|
||||
/// \file
|
||||
///
|
||||
/// This file defines a container for scope information used to
|
||||
/// generate debug info.
|
||||
///
|
||||
//===----------------------------------------------------------------------===//
|
||||
|
||||
#include "swift/SIL/SILDebugScope.h"
|
||||
#include "swift/SIL/SILFunction.h"
|
||||
|
||||
using namespace swift;
|
||||
|
||||
SILDebugScope::SILDebugScope(SILLocation Loc, SILFunction *SILFn,
|
||||
const SILDebugScope *ParentScope ,
|
||||
const SILDebugScope *InlinedCallSite)
|
||||
: Loc(Loc), InlinedCallSite(InlinedCallSite) {
|
||||
if (ParentScope)
|
||||
Parent = ParentScope;
|
||||
else {
|
||||
assert(SILFn && "no parent provided");
|
||||
Parent = SILFn;
|
||||
}
|
||||
}
|
||||
|
||||
SILDebugScope::SILDebugScope(SILLocation Loc)
|
||||
: Loc(Loc), InlinedCallSite(nullptr) {}
|
||||
|
||||
SILFunction *SILDebugScope::getInlinedFunction() const {
|
||||
if (Parent.isNull())
|
||||
return nullptr;
|
||||
|
||||
const SILDebugScope *Scope = this;
|
||||
while (Scope->Parent.is<const SILDebugScope *>())
|
||||
Scope = Scope->Parent.get<const SILDebugScope *>();
|
||||
assert(Scope->Parent.is<SILFunction *>() && "orphaned scope");
|
||||
return Scope->Parent.get<SILFunction *>();
|
||||
}
|
||||
|
||||
SILFunction *SILDebugScope::getParentFunction() const {
|
||||
if (InlinedCallSite)
|
||||
return InlinedCallSite->getParentFunction();
|
||||
if (auto *ParentScope = Parent.dyn_cast<const SILDebugScope *>())
|
||||
return ParentScope->getParentFunction();
|
||||
return Parent.get<SILFunction *>();
|
||||
}
|
||||
Reference in New Issue
Block a user