From 65d6a017f57ae8882fe41ca355661051a9be0a89 Mon Sep 17 00:00:00 2001 From: Anthony Latsis Date: Thu, 5 Oct 2023 08:53:47 +0300 Subject: [PATCH] [docs] FirstPullRequest: Rewrite "Asking for code review" section * Account for automatic review requests * Add a proper fallback course of action * Link out to commit access section on our official website --- docs/HowToGuides/FirstPullRequest.md | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/docs/HowToGuides/FirstPullRequest.md b/docs/HowToGuides/FirstPullRequest.md index 92c4ec442e5..7a3c565ba7c 100644 --- a/docs/HowToGuides/FirstPullRequest.md +++ b/docs/HowToGuides/FirstPullRequest.md @@ -124,17 +124,24 @@ show a helpful "Compare & Pull Request" button. ## Asking for code review -If you had an active discussion with someone on how to implement your change, -you can `@` mention them in the PR description and ask for code review. -If you directly implemented the change without any guidance from anyone else, -`@` mention someone from GitHub's suggested reviewers. If GitHub doesn't -make any suggestions, ask the [Code Owner](https://github.com/apple/swift/blob/main/CODE_OWNERS.TXT) based on the -component for your change. Please ask someone though! We don't want you to get -stuck because you were not sure who to ask for code review. +Collaborators and code owners are automatically requested for review per the +[CODEOWNERS](/.github/CODEOWNERS) file. If no one is automatically requested for +review, @mention and ask a suggested person under **Reviewers** to review your +changes. If no reviewer suggestions are shown either, please +[message][contributor-experience] the Contributor Experience Workgroup on the +Swift forums to sort out review requests for you. -At the beginning, contributors are not able to run the continuous integration -(CI) bot, which builds the project and runs tests. Please ask your code -reviewer(s) to invoke the bot for you. +You are welcome to invite other people for review as well — say, someone you +had an active discussion with on how to implement your change. +Anyone with a GitHub account can review or comment on changes proposed to +this repository! + +Contributors without +[write access](https://swift.org/contributing/#commit-access) are not able to +run the continuous integration (CI) bot, which builds the project and runs +tests. Please ask a code reviewer with write access to invoke the bot for you. + +[contributor-experience]: https://forums.swift.org/g/contributor-experience-workgroup ## Responding to code review comments