averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Runtime] Remove all use of read/write locks.

Browse Source 
Read/write locks are not as good as you'd think; a simple mutex is better in
almost all cases.

rdar://90776105
This commit is contained in:
Alastair Houghton
2022-03-29 16:03:07 +01:00
parent 0cf687aa2b
commit 66b9d21000
11 changed files with 28 additions and 1072 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
stdlib/public/runtime/MutexPThread.cpp
View File

@@ -106,38 +106,4 @@ bool MutexPlatformHelper::try_lock(pthread_mutex_t &mutex) {
#endif
void ReadWriteLockPlatformHelper::init(pthread_rwlock_t &rwlock) {
reportError(pthread_rwlock_init(&rwlock, nullptr));
}
void ReadWriteLockPlatformHelper::destroy(pthread_rwlock_t &rwlock) {
reportError(pthread_rwlock_destroy(&rwlock));
}
void ReadWriteLockPlatformHelper::readLock(pthread_rwlock_t &rwlock) {
reportError(pthread_rwlock_rdlock(&rwlock));
}
bool ReadWriteLockPlatformHelper::try_readLock(pthread_rwlock_t &rwlock) {
returnTrueOrReportError(pthread_rwlock_tryrdlock(&rwlock),
/* returnFalseOnEBUSY = */ true);
}
void ReadWriteLockPlatformHelper::writeLock(pthread_rwlock_t &rwlock) {
reportError(pthread_rwlock_wrlock(&rwlock));
}
bool ReadWriteLockPlatformHelper::try_writeLock(pthread_rwlock_t &rwlock) {
returnTrueOrReportError(pthread_rwlock_trywrlock(&rwlock),
/* returnFalseOnEBUSY = */ true);
}
void ReadWriteLockPlatformHelper::readUnlock(pthread_rwlock_t &rwlock) {
reportError(pthread_rwlock_unlock(&rwlock));
}
void ReadWriteLockPlatformHelper::writeUnlock(pthread_rwlock_t &rwlock) {
reportError(pthread_rwlock_unlock(&rwlock));
}
#endif // SWIFT_STDLIB_THREADING_PTHREADS