averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[stdlib] Stop inlining String.subscript

Browse Source 
`index(after:)`/`index(before:)` aren’t inlinable, so I don’t expect
force-inlining the subscript has much benefit.
This commit is contained in:
Karoy Lorentey
2022-03-24 18:33:46 -07:00
parent 298899264d
commit 67f01a1159
2 changed files with 9 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
stdlib/public/core/StringGuts.swift
View File

@@ -367,14 +367,12 @@ extension _StringGuts {
/// not set the flags that this method relies on. However, false positives
/// cannot happen: if this method detects a mismatch, then it is guaranteed to
/// be a real one.
@_alwaysEmitIntoClient // TODO(lorentey): Should this remain internal?
@inline(__always)
internal func ensureMatchingEncoding(_ i: String.Index) -> String.Index {
if _fastPath(!isForeign && i._canBeUTF8) { return i }
return _slowEnsureMatchingEncoding(i)
}
@_alwaysEmitIntoClient // TODO(lorentey): Should this remain internal?
@inline(never)
internal func _slowEnsureMatchingEncoding(_ i: String.Index) -> String.Index {
_internalInvariant(isForeign || !i._canBeUTF8)
@@ -430,7 +428,6 @@ extension _StringGuts {
/// - has an encoding that matches this string,
/// - is within the bounds of this string, and
/// - is aligned on a scalar boundary.
@_alwaysEmitIntoClient
internal func validateScalarIndex(_ i: String.Index) -> String.Index {
let i = ensureMatchingEncoding(i)
_precondition(i._encodedOffset < count, "String index is out of bounds")
@@ -463,7 +460,6 @@ extension _StringGuts {
/// - has an encoding that matches this string,
/// - is within the bounds of this string (including the `endIndex`), and
/// - is aligned on a scalar boundary.
@_alwaysEmitIntoClient
internal func validateInclusiveScalarIndex(
_ i: String.Index
) -> String.Index {
@@ -479,7 +475,6 @@ extension _StringGuts {
/// - has an encoding that matches this string,
/// - is within the bounds of this string (including the `endIndex`), and
/// - is aligned on a scalar boundary.
@_alwaysEmitIntoClient
internal func validateInclusiveScalarIndex(
_ i: String.Index,
from start: String.Index,
@@ -499,7 +494,6 @@ extension _StringGuts {
/// - have an encoding that matches this string,
/// - are within the bounds of this string, and
/// - are aligned on a scalar boundary.
@_alwaysEmitIntoClient
internal func validateScalarRange(
_ range: Range<String.Index>
) -> Range<String.Index> {
@@ -533,7 +527,6 @@ extension _StringGuts {
/// - have an encoding that matches this string,
/// - are within `start ..< end`, and
/// - are aligned on a scalar boundary.
@_alwaysEmitIntoClient
internal func validateScalarRange(
_ range: Range<String.Index>,
from start: String.Index,