averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[SourceKit] Cancel in-flight builds on editor.close

Browse Source 
When closing a document, cancel any in-flight
builds happening for it.

rdar://127126348
This commit is contained in:
Hamish Knight
2024-04-30 12:00:27 +01:00
parent 3fbad90a73
commit 69f2e26d35
6 changed files with 243 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tools/SourceKit/lib/SwiftLang/SwiftEditor.cpp
View File

@@ -707,6 +707,13 @@ public:
}
}
void cancelBuildsForCachedAST() {
if (!InvokRef)
return;
if (auto ASTMgr = this->ASTMgr.lock())
ASTMgr->cancelBuildsForCachedAST(InvokRef);
}
private:
std::vector<SwiftSemanticToken> takeSemanticTokens(
ImmutableTextSnapshotRef NewSnapshot);
@@ -2174,6 +2181,10 @@ void SwiftEditorDocument::removeCachedAST() {
Impl.SemanticInfo->removeCachedAST();
}
void SwiftEditorDocument::cancelBuildsForCachedAST() {
Impl.SemanticInfo->cancelBuildsForCachedAST();
}
void SwiftEditorDocument::applyFormatOptions(OptionsDictionary &FmtOptions) {
static UIdent KeyUseTabs("key.editor.format.usetabs");
static UIdent KeyIndentWidth("key.editor.format.indentwidth");
@@ -2444,8 +2455,14 @@ void SwiftLangSupport::editorClose(StringRef Name, bool RemoveCache) {
IFaceGenContexts.remove(Name);
}
if (Removed && RemoveCache)
Removed->removeCachedAST();
if (Removed) {
// Cancel any in-flight builds for the given AST.
Removed->cancelBuildsForCachedAST();
// Then remove the cached AST if we've been asked to do so.
if (RemoveCache)
Removed->removeCachedAST();
}
// FIXME: Report error if Name did not apply to anything ?
}