averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Sema: Removed unnecessary ValueDecl from AllowProtocolTypeMember

Browse Source 
Additionally removed the same unnecessary ValueDecl from
AllowProtocolTypeMemberFailure allowing it to extend MissingMemberFailure.
This commit is contained in:
Sam Lazarus
2019-05-30 01:03:46 -04:00
parent 049ec0f851
commit 6af91cc08d
6 changed files with 45 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/Sema/CSDiagnostics.cpp
View File

@@ -1963,7 +1963,7 @@ bool MissingMemberFailure::diagnoseAsError() {
bool AllowProtocolTypeMemberFailure::diagnoseAsError() {
auto *anchor = getRawAnchor();
Expr *baseExpr = getAnchor();
DeclNameLoc nameLoc;
if (auto *UDE = dyn_cast<UnresolvedDotExpr>(anchor)) {
@@ -1976,10 +1976,10 @@ bool AllowProtocolTypeMemberFailure::diagnoseAsError() {
} else if (auto *call = dyn_cast<CallExpr>(anchor)) {
baseExpr = call->getFn();
}
emitDiagnostic(getAnchor()->getLoc(),
diag::could_not_use_member_on_existential,
getBaseType(), getName())
diag::could_not_use_member_on_existential, getBaseType(),
getName())
.highlight(nameLoc.getSourceRange())
.highlight(baseExpr->getSourceRange());
return true;