averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

AST: Allow @inline(__always)/@inline(never) to be applied to properties and subscripts

Browse Source 
Previously we only permitted it on the accessor itself, but there is
no reason not to allow it on the storage declaration.

Fixes <https://bugs.swift.org/browse/SR-3624> / <rdar://problem/31865137>.
This commit is contained in:
Slava Pestov
2018-11-13 16:12:20 -05:00
parent f6c2caf64b
commit 6e4400567b
6 changed files with 50 additions and 96 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
lib/SIL/SILDeclRef.cpp
View File

@@ -528,26 +528,47 @@ IsSerialized_t SILDeclRef::isSerialized() const {
return IsNotSerialized;
}
/// \brief True if the function has noinline attribute.
/// \brief True if the function has an @inline(never) attribute.
bool SILDeclRef::isNoinline() const {
if (!hasDecl())
return false;
if (auto InlineA = getDecl()->getAttrs().getAttribute<InlineAttr>())
if (InlineA->getKind() == InlineKind::Never)
auto *decl = getDecl();
if (auto *attr = decl->getAttrs().getAttribute<InlineAttr>())
if (attr->getKind() == InlineKind::Never)
return true;
if (auto *semanticsA = getDecl()->getAttrs().getAttribute<SemanticsAttr>())
if (semanticsA->Value.equals("keypath.entry"))
if (auto *accessorDecl = dyn_cast<AccessorDecl>(decl)) {
auto *storage = accessorDecl->getStorage();
if (auto *attr = storage->getAttrs().getAttribute<InlineAttr>())
if (attr->getKind() == InlineKind::Never)
return true;
}
if (auto *attr = decl->getAttrs().getAttribute<SemanticsAttr>())
if (attr->Value.equals("keypath.entry"))
return true;
return false;
}
/// \brief True if the function has noinline attribute.
/// \brief True if the function has the @inline(__always) attribute.
bool SILDeclRef::isAlwaysInline() const {
if (!hasDecl())
return false;
if (auto InlineA = getDecl()->getAttrs().getAttribute<InlineAttr>())
if (InlineA->getKind() == InlineKind::Always)
auto *decl = getDecl();
if (auto attr = decl->getAttrs().getAttribute<InlineAttr>())
if (attr->getKind() == InlineKind::Always)
return true;
if (auto *accessorDecl = dyn_cast<AccessorDecl>(decl)) {
auto *storage = accessorDecl->getStorage();
if (auto *attr = storage->getAttrs().getAttribute<InlineAttr>())
if (attr->getKind() == InlineKind::Always)
return true;
}
return false;
}