averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #20320 from Azoy/random-readability

Browse Source 
[QoI][stdlib] Improve some random call sites
This commit is contained in:
Harlan Haskins
2018-11-09 11:31:43 -08:00
committed by GitHub
parent 55076e2144 309f46ebba
commit 703c5715cf
2 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
stdlib/public/core/CollectionAlgorithms.swift
View File

@@ -452,16 +452,15 @@ extension MutableCollection where Self : RandomAccessCollection {
public mutating func shuffle<T: RandomNumberGenerator>(
using generator: inout T
) {
let count = self.count
guard count > 1 else { return }
var amount = count
var currentIndex = startIndex
while amount > 1 {
let random = generator.next(upperBound: UInt(amount))
let random = Int.random(in: 0 ..< amount, using: &generator)
amount -= 1
swapAt(
currentIndex,
index(currentIndex, offsetBy: numericCast(random))
index(currentIndex, offsetBy: random)
)
formIndex(after: &currentIndex)
}