averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Macros] Diagnose when we forget to provide macro arguments.

Browse Source 
Unlike functions, you can't curry macros; diagnose when one omits the
arguments in a macro expansion of a macro that has a parameter list.
This commit is contained in:
Doug Gregor
2022-12-23 21:58:50 -08:00
parent 6bad02c50a
commit 71ca9c86e6
9 changed files with 135 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
lib/Sema/ConstraintSystem.cpp
View File

@@ -3569,12 +3569,34 @@ void ConstraintSystem::resolveOverload(ConstraintLocator *locator,
}
}
// If we have a macro, it can only be used in an expansion.
// If we have a macro, check for correct usage.
if (auto macro = dyn_cast<MacroDecl>(decl)) {
// Macro can only be used in an expansion. If we end up here, it's
// because we found a macro but are missing the leading '#'.
if (!locator->isForMacroExpansion()) {
// Record a fix here
(void)recordFix(MacroMissingPound::create(*this, macro, locator));
}
// If the macro has parameters but wasn't provided with any arguments,
// introduce a fix to add the arguments.
bool isCall;
switch (choice.getFunctionRefKind()) {
case FunctionRefKind::SingleApply:
case FunctionRefKind::DoubleApply:
isCall = true;
break;
case FunctionRefKind::Unapplied:
case FunctionRefKind::Compound:
// Note: macros don't have compound name references.
isCall = false;
break;
}
if (macro->parameterList && !isCall) {
// Record a fix here
(void)recordFix(MacroMissingArguments::create(*this, macro, locator));
}
}
}