averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Distributed] IRGen: Don't load arguments they turn into void in native schema

Browse Source 
If parameter type's size is `0` then we don't want to perform a load
at the current position in the buffer and have to move to the next
non-empty element.
This commit is contained in:
Pavel Yaskevich
2021-12-01 10:33:20 -08:00
committed by Pavel Yaskevich
parent 56fdf34f0a
commit 71e7355e8c
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
lib/IRGen/GenDistributed.cpp
View File

@@ -195,10 +195,7 @@ void DistributedAccessor::computeArguments(llvm::Value *argumentBuffer,
// 3. Adjust typed pointer to the alignement of the type.
auto alignedOffset = typeInfo.roundUpToTypeAlignment(IGF, eltPtr, paramTy);
// 4. Load argument value from the element pointer.
auto *argValue = IGF.Builder.CreateLoad(alignedOffset, "argval");
// 5. Create an exploded version of the type to pass as an
// 4. Create an exploded version of the type to pass as an
// argument to distributed method.
if (paramTy.isObject()) {
@@ -209,6 +206,13 @@ void DistributedAccessor::computeArguments(llvm::Value *argumentBuffer,
llvm_unreachable("indirect parameters are not supported");
}
// If schema is empty, skip to the next argument.
if (nativeSchema.empty())
continue;
// 5. Load argument value from the element pointer.
auto *argValue = IGF.Builder.CreateLoad(alignedOffset, "argval");
Explosion nonNativeParam;
nonNativeParam.add(argValue);
@@ -224,7 +228,8 @@ void DistributedAccessor::computeArguments(llvm::Value *argumentBuffer,
arguments.add(nativeParam.claimNext());
}
} else {
arguments.add(argValue);
// 5. Load argument value from the element pointer.
arguments.add(IGF.Builder.CreateLoad(alignedOffset, "argval"));
}
// 6. Move the offset to the beginning of the next element.