averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[omit-needless-words] Fix a bug found by -Wunused-result

Browse Source 
StringRef::drop_back() returns the new string; it doesn't mutate `this`.
This commit is contained in:
Ben Langmuir
2016-09-14 13:52:59 -07:00
parent 6d32a0b1f8
commit 7562c10333
3 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Basic/StringExtras.cpp
View File

@@ -669,7 +669,7 @@ static StringRef omitNeedlessWords(StringRef name,
NameRole::Partial, allPropertyNames, scratch);
if (shortenedNameWord == newShortenedNameWord &&
shortenedNameWord.back() == 'e') {
shortenedNameWord.drop_back();
shortenedNameWord = shortenedNameWord.drop_back();
newShortenedNameWord =
omitNeedlessWords(shortenedNameWord, typeName.CollectionElement,
NameRole::Partial, allPropertyNames, scratch);