averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[embedded] Make CMO's 'serialize everything' mode even more aggressive and allow serialization of private and shared functions

Browse Source
This commit is contained in:
Kuba Mracek
2023-09-21 16:35:58 -07:00
parent 40362469ca
commit 770dcd1614
5 changed files with 113 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

66
lib/SILOptimizer/IPO/CrossModuleOptimization.cpp
View File

@@ -60,11 +60,15 @@ class CrossModuleOptimization {
/// avoid code size increase.
bool conservative;
/// True if CMO should serialize literally everything in the module,
/// regardless of linkage.
bool everything;
typedef llvm::DenseMap<SILFunction *, bool> FunctionFlags;
public:
CrossModuleOptimization(SILModule &M, bool conservative)
: M(M), conservative(conservative) { }
CrossModuleOptimization(SILModule &M, bool conservative, bool everything)
: M(M), conservative(conservative), everything(everything) { }
void serializeFunctionsInModule();
@@ -164,9 +168,10 @@ void CrossModuleOptimization::serializeFunctionsInModule() {
// Start with public functions.
for (SILFunction &F : M) {
if (F.getLinkage() == SILLinkage::Public) {
if (canSerializeFunction(&F, canSerializeFlags, /*maxDepth*/ 64))
if (F.getLinkage() == SILLinkage::Public || everything) {
if (canSerializeFunction(&F, canSerializeFlags, /*maxDepth*/ 64)) {
serializeFunction(&F, canSerializeFlags);
}
}
}
}
@@ -189,6 +194,11 @@ bool CrossModuleOptimization::canSerializeFunction(
// it to true at the end of this function.
canSerializeFlags[function] = false;
if (everything) {
canSerializeFlags[function] = true;
return true;
}
if (DeclContext *funcCtxt = function->getDeclContext()) {
if (!canUseFromInline(funcCtxt))
return false;
@@ -392,6 +402,9 @@ static bool couldBeLinkedStatically(DeclContext *funcCtxt, SILModule &module) {
/// Returns true if the \p declCtxt can be used from a serialized function.
bool CrossModuleOptimization::canUseFromInline(DeclContext *declCtxt) {
if (everything)
return true;
if (!M.getSwiftModule()->canBeUsedForCrossModuleOptimization(declCtxt))
return false;
@@ -410,6 +423,9 @@ bool CrossModuleOptimization::canUseFromInline(DeclContext *declCtxt) {
/// Returns true if the function \p func can be used from a serialized function.
bool CrossModuleOptimization::canUseFromInline(SILFunction *function) {
if (everything)
return true;
if (DeclContext *funcCtxt = function->getDeclContext()) {
if (!canUseFromInline(funcCtxt))
return false;
@@ -439,14 +455,12 @@ bool CrossModuleOptimization::shouldSerialize(SILFunction *function) {
if (function->isSerialized())
return false;
if (everything)
return true;
if (function->hasSemanticsAttr("optimize.no.crossmodule"))
return false;
// In embedded Swift we serialize everything.
if (SerializeEverything ||
function->getASTContext().LangOpts.hasFeature(Feature::Embedded))
return true;
if (!conservative) {
// The basic heuristic: serialize all generic functions, because it makes a
// huge difference if generic functions can be specialized or not.
@@ -652,23 +666,29 @@ class CrossModuleOptimizationPass: public SILModuleTransform {
return;
if (!M.isWholeModule())
return;
bool conservative = false;
// In embedded Swift we serialize everything.
if (!M.getASTContext().LangOpts.hasFeature(Feature::Embedded)) {
switch (M.getOptions().CMOMode) {
case swift::CrossModuleOptimizationMode::Off:
return;
case swift::CrossModuleOptimizationMode::Default:
conservative = true;
break;
case swift::CrossModuleOptimizationMode::Aggressive:
conservative = false;
break;
}
bool everything = SerializeEverything;
switch (M.getOptions().CMOMode) {
case swift::CrossModuleOptimizationMode::Off:
break;
case swift::CrossModuleOptimizationMode::Default:
conservative = true;
break;
case swift::CrossModuleOptimizationMode::Aggressive:
conservative = false;
break;
case swift::CrossModuleOptimizationMode::Everything:
everything = true;
break;
}
CrossModuleOptimization CMO(M, conservative);
if (!everything &&
M.getOptions().CMOMode == swift::CrossModuleOptimizationMode::Off) {
return;
}
CrossModuleOptimization CMO(M, conservative, everything);
CMO.serializeFunctionsInModule();
}
};