averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Refactoring] Fix stack use after free in new async refactorings

Browse Source 
Resolves rdar://73984220
This commit is contained in:
Ben Barham
2021-02-05 08:36:02 +10:00
parent e2bac38348
commit 783c177956
7 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/IDE/Refactoring.cpp
View File

@@ -5249,7 +5249,8 @@ bool RefactoringActionConvertCallToAsyncAlternative::performChange() {
assert(CE &&
"Should not run performChange when refactoring is not applicable");
AsyncConversionStringBuilder Builder(SM, DiagEngine, AsyncHandlerDesc());
AsyncHandlerDesc TempDesc;
AsyncConversionStringBuilder Builder(SM, DiagEngine, TempDesc);
Builder.convertNode(CE);
if (DiagEngine.hadAnyError())
@@ -5281,7 +5282,8 @@ bool RefactoringActionConvertToAsync::performChange() {
assert(FD &&
"Should not run performChange when refactoring is not applicable");
AsyncConversionStringBuilder Builder(SM, DiagEngine, AsyncHandlerDesc());
AsyncHandlerDesc TempDesc;
AsyncConversionStringBuilder Builder(SM, DiagEngine, TempDesc);
Builder.convertFunction(FD);
if (DiagEngine.hadAnyError())