averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

AccessEnforcement: Fix analysis to include mayReleases as potentially

Browse Source 
executing unknown code

This means we have to claw back some performance by recognizing harmless
releases.

Such as releases on types we known don't call a deinit with unknown
side-effects.

rdar://143497196
rdar://143141695
This commit is contained in:
Arnold Schwaighofer
2025-02-02 10:05:18 -08:00
parent c95c45201e
commit 7a251af60c
12 changed files with 371 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/SILOptimizer/Transforms/AccessEnforcementOpts.cpp
View File

@@ -88,6 +88,7 @@
#include "swift/SILOptimizer/Analysis/DominanceAnalysis.h"
#include "swift/SILOptimizer/Analysis/LoopRegionAnalysis.h"
#include "swift/SILOptimizer/PassManager/Transforms.h"
#include "swift/SILOptimizer/Utils/InstOptUtils.h"
#include "swift/SILOptimizer/Utils/InstructionDeleter.h"
#include "swift/SILOptimizer/Utils/OwnershipOptUtils.h"
#include "llvm/ADT/MapVector.h"
@@ -633,7 +634,7 @@ void AccessConflictAndMergeAnalysis::propagateAccessSetsBottomUp(
}
// FIXME: Treat may-release conservatively in the analysis itself by
// adding a mayRelease flag, in addition to the unidentified flag.
accessResult.analyzeInstruction(&instr);
accessResult.analyzeInstruction(&instr, ASA->getDestructorAnalysis());
}
}
}
@@ -838,7 +839,8 @@ void AccessConflictAndMergeAnalysis::localDataFlowInBlock(RegionState &state,
visitFullApply(fullApply, state);
continue;
}
if (instr.mayRelease()) {
if (instr.mayRelease() &&
!isDestructorSideEffectFree(&instr, ASA->getDestructorAnalysis())) {
visitMayRelease(&instr, state);
}
}