averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

swift-module-digester: diagnose adding/removing @escaping as ABI breakage.

Browse Source
This commit is contained in:
Xi Ge
2018-09-27 17:42:55 -07:00
parent 6665b56e9d
commit 7b45ae9135
8 changed files with 91 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tools/swift-api-digester/ModuleAnalyzerNodes.cpp
View File

@@ -352,13 +352,19 @@ ArrayRef<DeclAttrKind> SDKNodeDecl::getDeclAttributes() const {
}
bool SDKNodeDecl::hasAttributeChange(const SDKNodeDecl &Another) const {
if (getDeclAttributes().size() != Another.getDeclAttributes().size())
return true;
for (auto K: getDeclAttributes()) {
if (!Another.hasDeclAttribute(K))
return true;
}
return false;
std::set<DeclAttrKind> Left(getDeclAttributes().begin(),
getDeclAttributes().end());
std::set<DeclAttrKind> Right(Another.getDeclAttributes().begin(),
Another.getDeclAttributes().end());
return Left != Right;
}
bool SDKNodeType::hasAttributeChange(const SDKNodeType &Another) const {
std::set<TypeAttrKind> Left(getTypeAttributes().begin(),
getTypeAttributes().end());
std::set<TypeAttrKind> Right(Another.getTypeAttributes().begin(),
Another.getTypeAttributes().end());
return Left != Right;
}
SDKNodeDecl *SDKNodeType::getClosestParentDecl() const {
@@ -614,7 +620,7 @@ bool SDKNode::operator==(const SDKNode &Other) const {
case SDKNodeKind::TypeFunc: {
auto Left = this->getAs<SDKNodeType>();
auto Right = (&Other)->getAs<SDKNodeType>();
if (!Left->getTypeAttributes().equals(Right->getTypeAttributes()))
if (Left->hasAttributeChange(*Right))
return false;
if (Left->hasDefaultArgument() != Right->hasDefaultArgument())
return false;