averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Basic/type_traits: use __is_identifier for some feature checks (#62993)

Browse Source 
* Basic/type_traits: use `__is_identifier` for some feature checks

When building on Alpine with Musl `__has_feature(is_trivially_constructible)` does not work, even though `__is_trivially_constructible` is defined and `__has_trivial_constructor` is deprecated. Same for `__is_trivially_destructible` and `__has_trivial_destructor` respectively.

* Basic/type_traits: use `__has_feature` or `__has_keyword`

That potentially makes these checks more future-proof in case more edge cases are introduced on different platforms.
This commit is contained in:
Max Desiatov
2023-01-12 22:08:06 +00:00
committed by GitHub
parent eaf35b75e4 fe373aa971
commit 7ccb605386
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
include/swift/Basic/type_traits.h
View File

@@ -16,6 +16,10 @@
#include <type_traits>
#include "swift/Basic/Compiler.h"
#ifndef __has_keyword
#define __has_keyword(__x) !(__is_identifier(__x))
#endif
#ifndef __has_feature
#define SWIFT_DEFINED_HAS_FEATURE
#define __has_feature(x) 0
@@ -45,7 +49,7 @@ struct IsTriviallyConstructible {
#if defined(_LIBCPP_VERSION) || SWIFT_COMPILER_IS_MSVC
// libc++ and MSVC implement is_trivially_constructible.
static const bool value = std::is_trivially_constructible<T>::value;
#elif __has_feature(is_trivially_constructible)
#elif __has_feature(is_trivially_constructible) || __has_keyword(__is_trivially_constructible)
static const bool value = __is_trivially_constructible(T);
#elif __has_feature(has_trivial_constructor) || __GNUC__ >= 5
static const bool value = __has_trivial_constructor(T);
@@ -59,7 +63,7 @@ struct IsTriviallyDestructible {
#if defined(_LIBCPP_VERSION) || SWIFT_COMPILER_IS_MSVC
// libc++ and MSVC implement is_trivially_destructible.
static const bool value = std::is_trivially_destructible<T>::value;
#elif __has_feature(is_trivially_destructible)
#elif __has_feature(is_trivially_destructible) || __has_keyword(__is_trivially_destructible)
static const bool value = __is_trivially_destructible(T);
#elif __has_feature(has_trivial_destructor) || __GNUC__ >= 5
static const bool value = __has_trivial_destructor(T);