averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Downgrade restrictions on self in actor init to warning

Browse Source 
These warnings will automatically turn into errors
when Swift 6 exists.
This commit is contained in:
Kavon Farvardin
2021-07-19 17:49:02 -07:00
parent 0c6063fd05
commit 7f83a534b3
2 changed files with 63 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/SILOptimizer/Mandatory/DefiniteInitialization.cpp
View File

@@ -2027,12 +2027,14 @@ void LifetimeChecker::reportIllegalUseForActorInit(
case ActorInitKind::Plain:
diagnose(Module, Use.Inst->getLoc(), diag::self_disallowed_actor_init,
false, ProblemDesc);
false, ProblemDesc)
.warnUntilSwiftVersion(6);
break;
case ActorInitKind::GlobalActorIsolated:
diagnose(Module, Use.Inst->getLoc(), diag::self_disallowed_actor_init,
true, ProblemDesc);
true, ProblemDesc)
.warnUntilSwiftVersion(6);
break;
}
@@ -2070,11 +2072,13 @@ void LifetimeChecker::handleLoadUseFailureForActorInit(
llvm::report_fatal_error("this actor init is never problematic!");
case ActorInitKind::Plain:
diagnose(Module, Use.Inst->getLoc(), diag::self_use_actor_init, false);
diagnose(Module, Use.Inst->getLoc(), diag::self_use_actor_init, false)
.warnUntilSwiftVersion(6);
break;
case ActorInitKind::GlobalActorIsolated:
diagnose(Module, Use.Inst->getLoc(), diag::self_use_actor_init, true);
diagnose(Module, Use.Inst->getLoc(), diag::self_use_actor_init, true)
.warnUntilSwiftVersion(6);
break;
}