averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Demangler: handle errors in demangleType

Browse Source 
Makes sure that invalid runtime type strings result in errors and not fail silently.
In worst case this could lead to wrong reconstructed metatypes which can result in all kind of memory corruption.

relates to rdar://129861211
This commit is contained in:
Erik Eckstein
2024-06-27 11:50:46 +02:00
parent 9580b21495
commit 7fe2befd31
4 changed files with 38 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/Runtime/demangleToMetadataObjC.swift
View File

@@ -40,9 +40,9 @@ func f1_composition_objc_protocol_P4(_: mainP4) { }
DemangleToMetadataTests.test("@objc protocols") {
expectEqual(type(of: f1_composition_objc_protocol),
_typeByName("yy4main2P1_pc")!)
_typeByName("y4main2P1_pc")!)
expectEqual(type(of: f1_composition_objc_protocol_P4),
_typeByName("yy4main0A2P4_pc")!)
_typeByName("y4main0A2P4_pc")!)
}
DemangleToMetadataTests.test("Objective-C classes") {
@@ -53,13 +53,13 @@ func f1_composition_NSCoding(_: NSCoding) { }
func f1_composition_P5(_: P5) { }
DemangleToMetadataTests.test("Objective-C protocols") {
expectEqual(type(of: f1_composition_NSCoding), _typeByName("yySo8NSCoding_pc")!)
expectEqual(type(of: f1_composition_NSCoding), _typeByName("ySo8NSCoding_pc")!)
// @objc Swift protocols can be found by their Objective-C names...
expectEqual(type(of: f1_composition_P5), _typeByName("yySo15P5RenamedInObjC_pc")!)
expectEqual(type(of: f1_composition_P5), _typeByName("ySo15P5RenamedInObjC_pc")!)
// ... but not their Swift names.
expectNil(_typeByName("yy4main2P5_pc"))
expectNil(_typeByName("y4main2P5_pc"))
}
DemangleToMetadataTests.test("Classes that don't exist") {