averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Sema: Don't clone TypeReprs in ConstraintSystem::shrink()

Browse Source
This commit is contained in:
Slava Pestov
2020-05-23 02:07:04 -04:00
parent 4eb5689115
commit 80919e9fe1
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Sema/CSSolver.cpp
View File

@@ -991,13 +991,8 @@ void ConstraintSystem::shrink(Expr *expr) {
auto typeRepr = castTypeLoc.getTypeRepr();
if (typeRepr && isSuitableCollection(typeRepr)) {
// Clone representative to avoid modifying in-place,
// FIXME: We should try and silently resolve the type here,
// instead of cloning representative.
auto coercionRepr = typeRepr->clone(CS.getASTContext());
// Let's try to resolve coercion type from cloned representative.
auto resolution = TypeResolution::forContextual(CS.DC, None);
auto coercionType = resolution.resolveType(coercionRepr);
auto coercionType = resolution.resolveType(typeRepr);
// Looks like coercion type is invalid, let's skip this sub-tree.
if (coercionType->hasError())