averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

cross-module-optimization: be more conservative with references to non-public functions

Browse Source 
We need to make serializing shared functions more robust. Until then, be more conservative with non-public functions.
This commit is contained in:
Erik Eckstein
2022-02-11 15:53:23 +01:00
parent 8c52853b9e
commit 80a22e332f
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/SILOptimizer/IPO/CrossModuleOptimization.cpp
View File

@@ -248,6 +248,12 @@ bool CrossModuleOptimization::canSerializeInstruction(SILInstruction *inst,
if (!callee) if (!callee)
return false; return false;
// In conservative mode we don't want to turn non-public functions into
// public functions, because that can increase code size. E.g. if the
// function is completely inlined afterwards.
if (conservative && !hasPublicVisibility(callee->getLinkage()))
return false;
// Recursivly walk down the call graph. // Recursivly walk down the call graph.
if (canSerializeFunction(callee, canSerializeFlags, maxDepth - 1)) if (canSerializeFunction(callee, canSerializeFlags, maxDepth - 1))
return true; return true;
@@ -260,12 +266,6 @@ bool CrossModuleOptimization::canSerializeInstruction(SILInstruction *inst,
if (!canUseFromInline(callee)) if (!canUseFromInline(callee))
return false; return false;
// In conservative mode we don't want to turn non-public functions into
// public functions, because that can increase code size. E.g. if the
// function is completely inlined afterwards.
if (conservative && callee->getLinkage() != SILLinkage::Public)
return false;
return true; return true;
} }
if (auto *GAI = dyn_cast<GlobalAddrInst>(inst)) { if (auto *GAI = dyn_cast<GlobalAddrInst>(inst)) {