averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[CodeCompletion] Store ignored arguments as Expr * instead of ConstraintLocators

Browse Source 
This avoids the construction of `ConstraintLocator`s.
This commit is contained in:
Alex Hoppen
2022-03-18 08:30:03 +01:00
parent a8cec01c6f
commit 82fc059018
4 changed files with 36 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/Sema/CSGen.cpp
View File

@@ -788,8 +788,7 @@ namespace {
CS(cs) {}
std::pair<bool, Expr *> walkToExprPre(Expr *expr) override {
if (CS.isArgumentIgnoredForCodeCompletion(
CS.getConstraintLocator(expr))) {
if (CS.isArgumentIgnoredForCodeCompletion(expr)) {
return {false, expr};
}
@@ -3648,8 +3647,7 @@ namespace {
std::pair<bool, Expr *> walkToExprPre(Expr *expr) override {
auto &CS = CG.getConstraintSystem();
if (CS.isArgumentIgnoredForCodeCompletion(
CS.getConstraintLocator(expr))) {
if (CS.isArgumentIgnoredForCodeCompletion(expr)) {
CG.setTypeForArgumentIgnoredForCompletion(expr);
return {false, expr};
}
@@ -3724,8 +3722,7 @@ namespace {
SmallVector<Expr *, 2> ignoredArgs;
getArgumentsAfterCodeCompletionToken(expr, CS, ignoredArgs);
for (auto ignoredArg : ignoredArgs) {
CS.markArgumentIgnoredForCodeCompletion(
CS.getConstraintLocator(ignoredArg));
CS.markArgumentIgnoredForCodeCompletion(ignoredArg);
}
}