averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Concurrency] Drop "Asynchronously" suffix from imported 'async' methods.

Browse Source 
The "Asynchronously" is a needless word for an "async" function. Remove
it.
This commit is contained in:
Doug Gregor
2020-10-21 21:57:30 -07:00
parent 24ea8becc8
commit 8521453af3
3 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/Basic/StringExtras.cpp
View File

@@ -1301,6 +1301,15 @@ bool swift::omitNeedlessWords(StringRef &baseName,
splitBaseName(baseName, argNames[0], paramTypes[0], firstParamName))
anyChanges = true;
// For a method imported as "async", drop the "Asynchronously" suffix from
// the base name. It is redundant with 'async'.
const StringRef asynchronously = "Asynchronously";
if (isAsync && camel_case::getLastWord(baseName) == asynchronously &&
baseName.size() > asynchronously.size()) {
baseName = baseName.drop_back(asynchronously.size());
anyChanges = true;
}
// Omit needless words based on parameter types.
for (unsigned i = 0, n = argNames.size(); i != n; ++i) {
// If there is no corresponding parameter, there is nothing to