Sema: Remove ConstraintSystemPhase::{Diagnostics,Finalization}

This commit is contained in:
Slava Pestov
2025-10-10 16:06:42 -04:00
parent a8d896ab8f
commit 8600cdcc2a
3 changed files with 2 additions and 23 deletions

View File

@@ -2098,8 +2098,6 @@ SolutionResult ConstraintSystem::salvage() {
llvm::errs() << "---Attempting to salvage and emit diagnostics---\n";
}
setPhase(ConstraintSystemPhase::Diagnostics);
// Attempt to solve again, capturing all states that come from our attempts to
// select overloads or bind type variables.
//
@@ -4797,10 +4795,6 @@ void SyntacticElementTargetKey::dump(raw_ostream &OS) const {
/// This is guaranteed to always emit an error message.
///
void ConstraintSystem::diagnoseFailureFor(SyntacticElementTarget target) {
setPhase(ConstraintSystemPhase::Diagnostics);
SWIFT_DEFER { setPhase(ConstraintSystemPhase::Finalization); };
auto &DE = getASTContext().Diags;
// If constraint system is in invalid state always produce