averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Rename @effects to @_effects

Browse Source 
@effects is too low a level, and not meant for general usage outside
the standard library. Therefore it deserves to be underscored like
other such attributes.
This commit is contained in:
Erik Little
2018-06-06 12:53:03 -04:00
parent 1ffc68722d
commit 863f3a19ff
29 changed files with 95 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/SILOptimizer/Analysis/SideEffectAnalysis.cpp
View File

@@ -334,7 +334,7 @@ bool FunctionSideEffects::setDefinedEffects(SILFunction *F) {
case EffectsKind::ReadNone:
return true;
case EffectsKind::ReadOnly:
// @effects(readonly) is worthless if we have owned parameters, because
// @_effects(readonly) is worthless if we have owned parameters, because
// the release inside the callee may call a deinit, which itself can do
// anything.
if (!F->hasOwnedParameters()) {
@@ -356,7 +356,7 @@ bool FunctionSideEffects::summarizeFunction(SILFunction *F) {
if (!F->empty())
ParamEffects.resize(F->getArguments().size());
// Handle @effects attributes
// Handle @_effects attributes
if (setDefinedEffects(F)) {
DEBUG(llvm::dbgs() << " -- has defined effects " << F->getName() << '\n');
return true;
@@ -463,7 +463,7 @@ bool FunctionSideEffects::summarizeCall(FullApplySite fullApply) {
}
if (SILFunction *SingleCallee = fullApply.getReferencedFunction()) {
// Does the function have any @effects?
// Does the function have any @_effects?
if (setDefinedEffects(SingleCallee))
return true;
}