averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #38112 from hborla/return-type-fixit-loc

Browse Source 
[Diagnostics] Correct the insert location of missing return type fix-it.
This commit is contained in:
Holly Borla
2021-06-28 16:29:34 -07:00
committed by GitHub
parent 5f44fc4dde e139c45702
commit 89418c6766
2 changed files with 48 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
test/Constraints/diagnostics.swift
View File

@@ -1213,6 +1213,43 @@ func voidFuncWithNestedVoidFunc() {
}
}
func voidFuncWithEffects1() throws {
return 1
// expected-error@-1 {{unexpected non-void return value in void function}}
// expected-note@-2 {{did you mean to add a return type?}}{{35-35= -> <#Return Type#>}}
}
func voidFuncWithEffects2() async throws {
return 1
// expected-error@-1 {{unexpected non-void return value in void function}}
// expected-note@-2 {{did you mean to add a return type?}}{{41-41= -> <#Return Type#>}}
}
// expected-error@+1 {{'async' must precede 'throws'}}
func voidFuncWithEffects3() throws async {
return 1
// expected-error@-1 {{unexpected non-void return value in void function}}
// expected-note@-2 {{did you mean to add a return type?}}{{41-41= -> <#Return Type#>}}
}
func voidFuncWithEffects4() async {
return 1
// expected-error@-1 {{unexpected non-void return value in void function}}
// expected-note@-2 {{did you mean to add a return type?}}{{34-34= -> <#Return Type#>}}
}
func voidFuncWithEffects5(_ closure: () throws -> Void) rethrows {
return 1
// expected-error@-1 {{unexpected non-void return value in void function}}
// expected-note@-2 {{did you mean to add a return type?}}{{65-65= -> <#Return Type#>}}
}
func voidGenericFuncWithEffects<T>(arg: T) async where T: CustomStringConvertible {
return 1
// expected-error@-1 {{unexpected non-void return value in void function}}
// expected-note@-2 {{did you mean to add a return type?}}{{49-49= -> <#Return Type#>}}
}
// Special cases: These should not offer a note + fix-it
func voidFuncExplicitType() -> Void {