averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Bypass lifetime diagnostics in interfaces for copied arguments.

Browse Source 
Briefly (April 2025), RawSpan._extracting, Span._extracting, and UTF8Span.span
returned a borrowed value that depended on a copied argument. Continue to
support those interfaces. The implementations were correct but needed an
explicit _overrideLifetime.
This commit is contained in:
Andrew Trick
2025-04-25 18:52:20 -07:00
parent 78758dad3f
commit 8a48cd979b
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
SwiftCompilerSources/Sources/Optimizer/FunctionPasses/LifetimeDependenceDiagnostics.swift
View File

@@ -219,6 +219,12 @@ private struct DiagnoseDependence {
log(" has dependent function result")
return .continueWalk
}
// Briefly (April 2025), RawSpan._extracting, Span._extracting, and UTF8Span.span returned a borrowed value that
// depended on a copied argument. Continue to support those interfaces. The implementations were correct but
// needed an explicit _overrideLifetime.
if let sourceFileKind = dependence.function.sourceFileKind, sourceFileKind == .interface {
return .continueWalk
}
}
return .abortWalk
}