averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[OpaqueValues] Addr-only consumes emit loadably.

Browse Source
This commit is contained in:
Nate Chandler
2023-08-22 11:15:11 -07:00
parent b15b4a03f1
commit 8c48ca2e8c
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/SILGen/SILGenExpr.cpp
View File

@@ -6199,7 +6199,7 @@ RValue RValueEmitter::visitConsumeExpr(ConsumeExpr *E, SGFContext C) {
return RValue(SGF, {optTemp->getManagedAddress()}, subType.getASTType()); return RValue(SGF, {optTemp->getManagedAddress()}, subType.getASTType());
} }
if (subType.isLoadable(SGF.F)) { if (subType.isLoadable(SGF.F) || !SGF.useLoweredAddresses()) {
ManagedValue mv = SGF.emitRValue(subExpr).getAsSingleValue(SGF, subExpr); ManagedValue mv = SGF.emitRValue(subExpr).getAsSingleValue(SGF, subExpr);
if (mv.getType().isTrivial(SGF.F)) if (mv.getType().isTrivial(SGF.F))
return RValue(SGF, {mv}, subType.getASTType()); return RValue(SGF, {mv}, subType.getASTType());

17
test/SILGen/opaque_values_silgen.swift
View File

@@ -782,3 +782,20 @@ func intIntoAnyHashableVar() {
func intIntoAnyHashableLet() { func intIntoAnyHashableLet() {
let anyHashable: AnyHashable = 0 let anyHashable: AnyHashable = 0
} }
// CHECK-LABEL: sil {{.*}}[ossa] @consumeExprOfOwnedAddrOnlyValue : {{.*}} {
// CHECK: bb0([[T:%[^,]+]] :
// CHECK: [[T_LIFETIME:%[^,]+]] = begin_borrow [[T]]
// CHECK: [[T_COPY:%[^,]+]] = copy_value [[T_LIFETIME]]
// CHECK: [[T_MOVE:%[^,]+]] = move_value [allows_diagnostics] [[T_COPY]]
// CHECK: [[SINK:%[^,]+]] = function_ref @sink
// CHECK: apply [[SINK]]<T>([[T_MOVE]])
// CHECK: end_borrow [[T_LIFETIME]]
// CHECK: destroy_value [[T]]
// CHECK-LABEL: } // end sil function 'consumeExprOfOwnedAddrOnlyValue'
@_silgen_name("consumeExprOfOwnedAddrOnlyValue")
func consumeExprOfOwnedAddrOnlyValue<T>(_ t: __owned T) {
sink(consume t)
}
@_silgen_name("sink")
func sink<T>(_ t: consuming T) {}