averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[sil-linker] Improve the implementation of the hasSILFunction API

Browse Source 
It it now possible to check if a function with a given name and a given linkage exists in one of the modules,
even if the current module contains a function with this name but a difference linkage.
This is useful e.g. for performing a lookup of pre-specializations.
This commit is contained in:
Roman Levenstein
2016-04-13 13:50:19 -07:00
parent e806fd2d1d
commit 9234eb3ca7
7 changed files with 126 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
lib/SIL/SILModule.cpp
View File

@@ -484,12 +484,48 @@ bool SILModule::linkFunction(StringRef Name, SILModule::LinkingMode Mode) {
}
SILFunction *SILModule::hasFunction(StringRef Name, SILLinkage Linkage) {
assert(!lookUpFunction(Name) && "hasFunction should be only called for "
"functions that are not contained in the "
"SILModule yet");
return SILLinkerVisitor(*this, getSILLoader(),
SILModule::LinkingMode::LinkNormal)
.lookupFunction(Name, Linkage);
SILFunction *F = lookUpFunction(Name);
assert((Linkage == SILLinkage::Public ||
Linkage == SILLinkage::PublicExternal) &&
"Only a lookup of public functions is supported currently");
// Nothing to do if the current module has a required function
// with a proper linkage.
if (F && F->getLinkage() == Linkage)
return F;
assert((!F || F->getLinkage() != Linkage) &&
"hasFunction should be only called for functions that are not "
"contained in the SILModule yet or do not have a required linkage");
(void)F;
SILLinkerVisitor Visitor(*this, getSILLoader(),
SILModule::LinkingMode::LinkNormal);
if (Visitor.hasFunction(Name, Linkage)) {
if (!F) {
// Load the function.
F = Visitor.lookupFunction(Name, Linkage);
assert(F && "Function should be present");
assert(F->getLinkage() == Linkage &&
"SILFunction has a wrong linkage");
}
// If a function exists already and it is a non-optimizing
// compilaiton, simply convert it into an external declaration,
// so that a compiled version from the shared library is used.
if (F->isDefinition() &&
F->getModule().getOptions().Optimization <
SILOptions::SILOptMode::Optimize) {
F->convertToDeclaration();
}
if (F->isExternalDeclaration())
F->setFragile(IsFragile_t::IsNotFragile);
F->setLinkage(Linkage);
} else {
F = nullptr;
}
return F;
}
void SILModule::linkAllWitnessTables() {