averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Diagnostics] Port pattern-matching mismatch diagnostic

Browse Source 
Port diagnostics associated with implicit use of `~=` operator
which is used in `case` statements.
This commit is contained in:
Pavel Yaskevich
2019-09-02 10:36:35 -07:00
parent 1a57fc403a
commit 93b39c9c23
6 changed files with 112 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
lib/Sema/CSDiagnostics.cpp
View File

@@ -4455,6 +4455,9 @@ bool ArgumentMismatchFailure::diagnoseAsError() {
if (diagnoseArchetypeMismatch())
return true;
if (diagnosePatternMatchingMismatch())
return true;
auto argType = getFromType();
auto paramType = getToType();
@@ -4488,17 +4491,46 @@ bool ArgumentMismatchFailure::diagnoseAsNote() {
auto argToParam = locator->findFirst<LocatorPathElt::ApplyArgToParam>();
assert(argToParam);
if (auto overload = getChoiceFor(getRawAnchor())) {
if (auto *decl = overload->choice.getDeclOrNull()) {
emitDiagnostic(decl, diag::candidate_has_invalid_argument_at_position,
getToType(), argToParam->getParamIdx());
return true;
}
if (auto *decl = getDecl()) {
emitDiagnostic(decl, diag::candidate_has_invalid_argument_at_position,
getToType(), argToParam->getParamIdx());
return true;
}
return false;
}
bool ArgumentMismatchFailure::diagnosePatternMatchingMismatch() const {
if (!isArgumentOfPatternMatchingOperator(getLocator()))
return false;
auto *op = cast<BinaryExpr>(getRawAnchor());
auto *lhsExpr = op->getArg()->getElement(0);
auto *rhsExpr = op->getArg()->getElement(1);
auto lhsType = getType(lhsExpr)->getRValueType();
auto rhsType = getType(rhsExpr)->getRValueType();
auto diagnostic =
lhsType->is<UnresolvedType>()
? emitDiagnostic(
getLoc(), diag::cannot_match_unresolved_expr_pattern_with_value,
rhsType)
: emitDiagnostic(getLoc(), diag::cannot_match_expr_pattern_with_value,
lhsType, rhsType);
diagnostic.highlight(lhsExpr->getSourceRange());
diagnostic.highlight(rhsExpr->getSourceRange());
if (auto optUnwrappedType = rhsType->getOptionalObjectType()) {
if (lhsType->isEqual(optUnwrappedType)) {
diagnostic.fixItInsertAfter(lhsExpr->getEndLoc(), "?");
}
}
return true;
}
bool ArgumentMismatchFailure::diagnoseArchetypeMismatch() const {
auto *argTy = getFromType()->getAs<ArchetypeType>();
auto *paramTy = getToType()->getAs<ArchetypeType>();