averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[SourceKit] Change return value of functions in EditorConsumer to void

Browse Source 
We were always returning true from those functions in  SKEditorConsumer
and false in the test consumers. On the client side we would then ignore
the return value. So it's clearer to have the functions not return
anything.
This commit is contained in:
Alex Hoppen
2018-07-31 14:16:32 -07:00
parent 293e8bd0bd
commit 9bbe441160
5 changed files with 86 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
unittests/SourceKit/SwiftLang/EditingTest.cpp
View File

@@ -43,18 +43,15 @@ private:
bool syntaxMapEnabled() override { return true; }
bool handleSyntaxMap(unsigned Offset, unsigned Length, UIdent Kind) override {
return false;
void handleSyntaxMap(unsigned Offset, unsigned Length, UIdent Kind) override {
}
bool handleSemanticAnnotation(unsigned Offset, unsigned Length,
UIdent Kind, bool isSystem) override {
return false;
}
void handleSemanticAnnotation(unsigned Offset, unsigned Length, UIdent Kind,
bool isSystem) override {}
bool documentStructureEnabled() override { return false; }
bool beginDocumentSubStructure(unsigned Offset, unsigned Length,
void beginDocumentSubStructure(unsigned Offset, unsigned Length,
UIdent Kind, UIdent AccessLevel,
UIdent SetterAccessLevel,
unsigned NameOffset,
@@ -69,42 +66,28 @@ private:
StringRef SelectorName,
ArrayRef<StringRef> InheritedTypes,
ArrayRef<std::tuple<UIdent, unsigned, unsigned>> Attrs) override {
return false;
}
bool endDocumentSubStructure() override { return false; }
void endDocumentSubStructure() override {}
bool handleDocumentSubStructureElement(UIdent Kind,
unsigned Offset,
unsigned Length) override {
return false;
}
void handleDocumentSubStructureElement(UIdent Kind, unsigned Offset,
unsigned Length) override {}
bool recordAffectedRange(unsigned Offset, unsigned Length) override {
return false;
}
bool recordAffectedLineRange(unsigned Line, unsigned Length) override {
return false;
}
void recordAffectedRange(unsigned Offset, unsigned Length) override {}
bool recordFormattedText(StringRef Text) override { return false; }
void recordAffectedLineRange(unsigned Line, unsigned Length) override {}
bool setDiagnosticStage(UIdent diagStage) override {
DiagStage = diagStage;
return true;
}
bool handleDiagnostic(const DiagnosticEntryInfo &Info,
void recordFormattedText(StringRef Text) override {}
void setDiagnosticStage(UIdent diagStage) override { DiagStage = diagStage; }
void handleDiagnostic(const DiagnosticEntryInfo &Info,
UIdent DiagStage) override {
Diags.push_back(Info);
return true;
}
bool handleSourceText(StringRef Text) override { return false; }
bool handleSyntaxTree(const swift::syntax::SourceFileSyntax &SyntaxTree,
std::unordered_set<unsigned> ReusedNodeIds) override {
return false;
}
void handleSourceText(StringRef Text) override {}
void handleSyntaxTree(const swift::syntax::SourceFileSyntax &SyntaxTree,
std::unordered_set<unsigned> ReusedNodeIds) override {}
SyntaxTreeTransferMode syntaxTreeTransferMode() override {
return SyntaxTreeTransferMode::Off;
@@ -112,9 +95,8 @@ private:
bool syntaxReuseInfoEnabled() override { return false; }
bool handleSyntaxReuseRegions(
std::vector<SourceFileRange> ReuseRegions) override {
return false;
void
handleSyntaxReuseRegions(std::vector<SourceFileRange> ReuseRegions) override {
}
};