averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

AST,DependencyScan,IRGen,Serialization,Tooling: track library style (#78777)

Browse Source 
Track if the dependency is static or dynamic. This is in preparation for
helping rename the static library to differentiate it from import
libraries.
This commit is contained in:
Saleem Abdulrasool
2025-02-06 13:22:56 -08:00
committed by GitHub
parent 8d69807ed6
commit 9c85fbc8da
26 changed files with 158 additions and 96 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
lib/Serialization/ModuleFileSharedCore.cpp
View File

@@ -1583,13 +1583,31 @@ ModuleFileSharedCore::ModuleFileSharedCore(
}
case input_block::LINK_LIBRARY: {
uint8_t rawKind;
bool isStaticLibrary;
bool shouldForceLink;
input_block::LinkLibraryLayout::readRecord(scratch, rawKind,
shouldForceLink);
if (Bits.IsStaticLibrary)
shouldForceLink = false;
isStaticLibrary, shouldForceLink);
// FIXME: the propagation of the static library is a problem as it
// causes over-linkage of the dependencies and hinders DCE. This
// results in significant code size increase on Windows.
//
// We propogate it on Darwin as ld64 has special handling for
// preserving the Swift conformances. The `_swift_FORCE_LOAD_$_`
// symbols will force the static library to be scanned for inclusion.
// The other platforms do not have this special handling and so this
// will only slow down the linker and not guarantee any conformances
// to be preserved. The same behaviour is better achieved with `-(`,
// `-)` to preserve the whole archive.
//
// When using dynamic libraries, the force load symbol will force the
// shared library to be loaded and register the conformances.
bool EmitForceLinkSymbol = shouldForceLink;
if (!llvm::Triple(TargetTriple).isOSDarwin())
EmitForceLinkSymbol = !isStaticLibrary && shouldForceLink;
if (auto libKind = getActualLibraryKind(rawKind))
LinkLibraries.push_back({blobData, *libKind, shouldForceLink});
LinkLibraries.emplace_back(blobData, *libKind, isStaticLibrary,
EmitForceLinkSymbol);
// else ignore the dependency...it'll show up as a linker error.
break;
}